-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GR-54697] Implement debuginfo generation at image-runtime. #10522
Open
graalvmbot
wants to merge
27
commits into
master
Choose a base branch
from
doma/GR-54697
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ime Debug Info Rework debug entries Remove separate Runtime Debuginfo sections
…g Entries for LocalValues and ForeignTypes, some refactoring
Create file and dir indices in class entries Update GDB JIT compilation interface to only use a header file
6dfef33
to
a6101eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux native-image supports generating images with dwarf-debuginfo. This allows advanced users to debug image execution with GDB.
Since debuginfo is generated as part of the image build process it is only providing debug support for the AOT compiled methods in an image. For methods that get compiled at image run-time (as part of truffle runtime compilation) there is currently no debuginfo available.
To fix this problem the process of generating debuginfo must also happen at image runtime whenever a new method gets compiled and is about to be registered in the run-time code-cache. This requires code that is currently only used at build-time (hosted) to be made usable also for inclusion in the image itself. The relevant parts of the hosted code need to be refactored as needed.
Once runtime-debuginfo is generated GDB needs to be notified about it. This needs to happen via the GDB JIT Interface. Note that it also required that GDB needs to be notified that run-time debuginfo is no more valid in case a run-time compiled method gets removed from the run-time code-cache (e.g. due to deoptimization).
The existing debuginfo testing needs to be extended to also test the run-time debuginfo generation.