Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: rewrite for Zig 0.12/0.13 #28

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Conversation

tranzystorekk
Copy link
Contributor

Description

Partially taken from #8

Change summary:

  • zig-clap updated to 0.8.0, with necessary changes
  • removed the main.zig test, the cli parser chokes on the args received from the test invocation itself, and arguably this test isn't that useful to begin with
  • code in gen.zig adjusted for type casting breaking changes back from 0.11
  • necessary build system changes for the new optimize terminology
  • other build system changes re: imports and modules
  • std.os -> std.posix rename
  • {write,read}IntLittle functions now are called {write,read}Int and accept an endian argument

Motivation and Context

How Has This Been Tested?

zig build
zig build -Doptimize=ReleaseSafe
zig build --summary all test
# run the built linuxwave and compare output to 0.1.5

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tranzystorekk
Copy link
Contributor Author

Seems https://hub.docker.com/r/euantorano/zig from the Dockerfile is no longer active...

@tranzystorekk
Copy link
Contributor Author

tranzystorekk commented Jul 8, 2024

Added some compatibility changes so that we can build for both zig 0.12 and 0.13:

  • use b.path() to specify module paths in build.zig
  • bump zig-clap to 0.9.1
  • gitignore .zig-cache/ as well

@tranzystorekk tranzystorekk changed the title Zig 0.12 Zig 0.12/0.13 Sep 30, 2024
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO

@orhun orhun changed the title Zig 0.12/0.13 feat!: rewrite for Zig 0.12/0.13 Oct 7, 2024
@orhun orhun merged commit e18d8c1 into orhun:main Oct 7, 2024
5 of 7 checks passed
@orhun orhun mentioned this pull request Oct 7, 2024
10 tasks
@tranzystorekk tranzystorekk deleted the zig-0.12 branch October 20, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants