refactor(SQS): switch to a more performant JSON lib #7065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
changed the title
p0mvn
added
A:no-changelog
V:state/compatible/no_backport
|
NIce job! If we want to completely eliminate this time, we can also switch to using one of the JSON libs that code-gens deserialization logic. (So it all stays on stack, no reflection/runtime tricks, and minimal heap allocation. This is where all time goes in traditional unmarshalling) |
ValarDragon
approved these changes
Dec 11, 2023
|
Should we make an issue to use this in the SDK for import/export genesis? |
p0mvn
added
V:state/compatible/backport
mergify bot
pushed a commit
that referenced
this pull request
Dec 11, 2023
* refactor(SQS): switch to a more performant t JSON lib * godoc (cherry picked from commit 6506d0d) # Conflicts: # go.mod # ingest/sqs/chain_info/repository/redis/redis_chain_info_repository.go # ingest/sqs/domain/router.go # ingest/sqs/pools/repository/redis/redis_pools_repository.go # ingest/sqs/router/repository/redis/redis_router_repository.go # ingest/sqs/router/usecase/routertesting/parsing/mainnet_pools.go # ingest/sqs/router/usecase/routertesting/parsing/mainnet_pools_test.go # ingest/sqs/system/delivery/http/system_http_handler.go # ingest/sqs/tokens/usecase/tokens_usecase.go
mergify bot
pushed a commit
that referenced
this pull request
Dec 11, 2023
* refactor(SQS): switch to a more performant t JSON lib * godoc (cherry picked from commit 6506d0d)
This was referenced Dec 11, 2023
p0mvn
added a commit
that referenced
this pull request
Dec 11, 2023
ValarDragon
pushed a commit
that referenced
this pull request
Dec 11, 2023
* refactor(SQS): switch to a more performant t JSON lib * godoc (cherry picked from commit 6506d0d) Co-authored-by: Roman <[email protected]>
p0mvn
added a commit
that referenced
this pull request
Dec 11, 2023
…7070) Co-authored-by: roman <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Based on profiling, JSON unmarshaling is a big bottleneck in SQS. Accordingly, we switch the library to a more performant one - https://github.com/json-iterator/go
Based on the new profile, the overall share of the unmarshaling is not as large as before.
Additionally, load testing shows an improvement.
Old load testing:
New load testing:
Old profile (incomplete):
New profile:
Testing and Verifying
This change is already covered by existing tests, such as (please describe tests).
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)