Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): require php 8.1 #62

Closed
wants to merge 1 commit into from
Closed

chore(deps): require php 8.1 #62

wants to merge 1 commit into from

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Jan 7, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #62 (c0f3b5d) into master (333f5eb) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             master      #62    +/-   ##
==========================================
  Coverage     57.53%   57.53%            
- Complexity        0      128   +128     
==========================================
  Files             7        7            
  Lines           332      332            
==========================================
  Hits            191      191            
  Misses          141      141            

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Spriz
Copy link

Spriz commented May 8, 2023

Curious question - why bump PHP requirements if not using any 8.1 specific features? 🤔

@simPod
Copy link
Contributor Author

simPod commented May 8, 2023

Cannot use 8.1 specific features without the bump.

@ruudk ruudk mentioned this pull request Aug 25, 2023
@ruudk
Copy link
Contributor

ruudk commented Aug 25, 2023

Can be closed, handled in #67

@mcg-web mcg-web closed this Aug 25, 2023
@simPod simPod deleted the 80 branch August 25, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants