-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable linter commands #4482
base: main
Are you sure you want to change the base?
Conversation
🦙 MegaLinter status:
|
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
✅ API | spectral | 1 | 0 | 1.74s | |
bash-exec | 6 | 1 | 0.03s | ||
✅ BASH | shellcheck | 6 | 0 | 0.21s | |
✅ BASH | shfmt | 6 | 0 | 0 | 0.77s |
✅ COPYPASTE | jscpd | yes | no | 2.81s | |
✅ DOCKERFILE | hadolint | 129 | 0 | 23.63s | |
✅ JSON | jsonlint | 20 | 0 | 0.2s | |
✅ JSON | v8r | 22 | 0 | 13.71s | |
markdownlint | 267 | 0 | 303 | 23.54s | |
✅ MARKDOWN | markdown-table-formatter | 267 | 0 | 0 | 159.91s |
bandit | 215 | 66 | 2.96s | ||
✅ PYTHON | black | 215 | 0 | 0 | 4.4s |
✅ PYTHON | flake8 | 215 | 0 | 1.75s | |
✅ PYTHON | isort | 215 | 0 | 0 | 1.21s |
✅ PYTHON | mypy | 215 | 0 | 16.64s | |
✅ PYTHON | pylint | 215 | 0 | 33.21s | |
✅ PYTHON | ruff | 215 | 0 | 0 | 0.8s |
✅ REPOSITORY | checkov | yes | no | 35.43s | |
✅ REPOSITORY | git_diff | yes | no | 0.47s | |
grype | yes | 26 | 12.71s | ||
✅ REPOSITORY | secretlint | yes | no | 11.55s | |
✅ REPOSITORY | trivy | yes | no | 14.48s | |
✅ REPOSITORY | trivy-sbom | yes | no | 0.38s | |
trufflehog | yes | 1 | 54.61s | ||
✅ SPELL | cspell | 718 | 0 | 12.65s | |
lychee | 349 | 17 | 9.23s | ||
✅ XML | xmllint | 3 | 0 | 0 | 0.93s |
✅ YAML | prettier | 160 | 0 | 0 | 3.4s |
✅ YAML | v8r | 102 | 0 | 29.45s | |
✅ YAML | yamllint | 161 | 0 | 3.01s |
See detailed report in MegaLinter reports
I didn't really understood the issue nor this fix.. |
cc @echoix |
@bdovaz i get it, it seems nice :) Please can you
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plz check comments :)
As it is impacting, I'd also like a double-check from @echoix :)
self.process_linters_parallel(active_linters, linters_do_fixes) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you see a use case where we need it in post commands ?
if not you can remove this part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't think of it right now but “it's free” to have the same functionality in both pre and post, isn't it? Better to have it than not to have it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think @echoix?
if linter.post_commands is not None: | ||
filtered_commands: list = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not needed for post_commands, plz remove this part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read the comment above
Resolves #4015
Let's see what you think @nvuillam