Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies, including pa11y-ci to 3 from 2 #106

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

danyalaytekin
Copy link
Member

@danyalaytekin danyalaytekin commented Nov 10, 2023

Main changes

  • bump pa11y-ci to 3 from 2
  • use Node 14 up from 8
  • use Ruby 3 up from 2 and update some deps
  • describe how to install Ruby and Node stuff and to validate/test workflows locally
  • some tidying up
    • use Pa11y's .editorconfig
    • gently forbid asdf because it caused me some trouble a while back here
    • add command make browse (jekyll serve --open is available but adding --open it would interfere with build and it can't be run again without restarting server)
    • build badge

@danyalaytekin danyalaytekin self-assigned this Nov 10, 2023
@danyalaytekin danyalaytekin marked this pull request as ready for review November 10, 2023 11:07
@jpw
Copy link

jpw commented Nov 10, 2023

I know nothing about Ruby so unable to assist with reviewing this one sadly.

@jpw jpw removed their request for review November 10, 2023 13:43
Copy link
Member

@hollsk hollsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks GREAT to me, thanks @danyalaytekin 🙏

@sonniesedge
Copy link
Contributor

What idiot asked me to review something? 😂

@sonniesedge
Copy link
Contributor

What idiot asked me to review something? 😂

Oh hai @danyalaytekin 😂

@danyalaytekin danyalaytekin added the dependencies Pull requests that update a dependency file label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants