Update openapi_first and use it's coverage thing #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahx
force-pushed
the
update-openapi_first
branch
2 times, most recently
from
5ee3444 to
4936058
Compare
This removes skip_oas_request_validation, because the app wrapped by OpenapiFirst::Test.app does not raise errors, but just tracks requests/responses to collect coverage data.
ahx
force-pushed
the
update-openapi_first
branch
from
4936058 to
35ecefe
Compare
Fix API coverage issue. This results in removal of this test output: ✓ POST /contracts/publish (application/json) ✓ 200(application/hal+json) ❌ 400(application/problem+json) – No responses tracked! ✓ 400(application/hal+json) ✓ 409(application/json) The overal API validation coverage of this run is: 80% Exiting with status 2 (failure), because API coverage was 80% instead of 100%!
impurist
approved these changes
Feb 20, 2025
|
Thanks Andreas, appreciate you revisiting this, and thanks for your library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Years ago I added OpenapiFirst::Coverage, but deleted it later on and left you with your own patch. I am sorry.
Now openapi_first has a better coverage feature with a hopefully more usable API (any feedback is very welcome). This PR replaces the old patch with that implementation.
Currently this PR fails with the following output. Maybe because the400 (application/problem+json)response is not covered during tests, maybe there is another issue. I am happy to look into that if you like the overall approach.UPDATE: I have added a commit to solve complaint of openapi_first.