Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP docs site to link check excludelist #383

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Add PHP docs site to link check excludelist #383

merged 2 commits into from
Jan 18, 2022

Conversation

fg-j
Copy link

@fg-j fg-j commented Dec 20, 2021

Summary

For some reason, the PHP docs site consistently fails the muffet link check. See raviqqe/muffet#184. If/when that bug is resolved, the site could be removed from the excludelist.

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

since it consistently fails link checking
@fg-j fg-j requested a review from a team as a code owner December 20, 2021 16:22
@github-actions
Copy link

github-actions bot commented Dec 20, 2021

PR deployed to: https://paketo-stage--php-docs-s5un3eih.web.app
Expires at: 2021-12-23T19:08:36.994690357Z (in 72h)

Co-authored-by: Forest Eckhardt <[email protected]>
@ForestEckhardt ForestEckhardt merged commit 7a64801 into main Jan 18, 2022
@ForestEckhardt ForestEckhardt deleted the php-docs branch January 18, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants