Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASAP 401 Fix #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ASAP 401 Fix #90

wants to merge 1 commit into from

Conversation

zendoodles
Copy link
Contributor

Updates shrinkwrap to remove dependency on unavailable uberinternal repo.

19959 verbose type Error
19960 verbose stack Error: 401 Unauthorized: asap@https://unpm.uberinternal.com/asap/-/asap-2.0.4.tgz
19960 verbose stack     at fetch.then.res (/Users/zendoodles/.nvm/versions/node/v7.10.0/lib/node_modules/npm/node_modules/pacote/lib/fetchers/registry/fetch.js:42:19)
19960 verbose stack     at tryCatcher (/Users/zendoodles/.nvm/versions/node/v7.10.0/lib/node_modules/npm/node_modules/bluebird/js/release/util.js:16:23)
19960 verbose stack     at Promise._settlePromiseFromHandler (/Users/zendoodles/.nvm/versions/node/v7.10.0/lib/node_modules/npm/node_modules/bluebird/js/release/promise.js:512:31)
19960 verbose stack     at Promise._settlePromise (/Users/zendoodles/.nvm/versions/node/v7.10.0/lib/node_modules/npm/node_modules/bluebird/js/release/promise.js:569:18)
19960 verbose stack     at Promise._settlePromise0 (/Users/zendoodles/.nvm/versions/node/v7.10.0/lib/node_modules/npm/node_modules/bluebird/js/release/promise.js:614:10)
19960 verbose stack     at Promise._settlePromises (/Users/zendoodles/.nvm/versions/node/v7.10.0/lib/node_modules/npm/node_modules/bluebird/js/release/promise.js:693:18)
19960 verbose stack     at Async._drainQueue (/Users/zendoodles/.nvm/versions/node/v7.10.0/lib/node_modules/npm/node_modules/bluebird/js/release/async.js:133:16)
19960 verbose stack     at Async._drainQueues (/Users/zendoodles/.nvm/versions/node/v7.10.0/lib/node_modules/npm/node_modules/bluebird/js/release/async.js:143:10)
19960 verbose stack     at Immediate.Async.drainQueues (/Users/zendoodles/.nvm/versions/node/v7.10.0/lib/node_modules/npm/node_modules/bluebird/js/release/async.js:17:14)
19960 verbose stack     at runCallback (timers.js:672:20)
19960 verbose stack     at tryOnImmediate (timers.js:645:5)
19960 verbose stack     at processImmediate [as _immediateCallback] (timers.js:617:5)
19961 verbose cwd /Users/zendoodles/Projects/zendoodles/hatter
19962 verbose Darwin 16.7.0
19963 verbose argv "/Users/zendoodles/.nvm/versions/node/v7.10.0/bin/node" "/Users/zendoodles/.nvm/versions/node/v7.10.0/bin/npm" "install"
19964 verbose node v7.10.0
19965 verbose npm  v5.4.2
19966 error code E401
19967 error 401 Unauthorized: asap@https://unpm.uberinternal.com/asap/-/asap-2.0.4.tgz
19968 verbose exit [ 1, true ]

@becw
Copy link
Member

becw commented Oct 19, 2017

This looks good to me -- it fixes a dependency issue that has been cropping up for lots of folks.

@becw
Copy link
Member

becw commented Oct 19, 2017

I guess I should actually TEST Butler with these updated packages, though...

@becw
Copy link
Member

becw commented Oct 19, 2017

When I run npm install with this branch in my package.json like this:

{
  "name": "medidata-styleguide",
  "version": "1.0.0",
  "description": "Styleguide for Medidata.",
  "main": "index.js",
  "scripts": {
    "butler": "node_modules/butler/node_modules/.bin/gulp --gulpfile node_modules/butler/Gulpfile.js",
    "develop": "node_modules/butler/node_modules/.bin/gulp --gulpfile node_modules/butler/Gulpfile.js develop",
    "test": "node_modules/butler/node_modules/.bin/gulp --gulpfile node_modules/butler/Gulpfile.js test",
    "deploy": "node_modules/butler/node_modules/.bin/gulp --gulpfile node_modules/butler/Gulpfile.js spress-deploy"
  },
  "repository": {
    "type": "git",
    "url": "git+ssh://[email protected]/palantirnet/medidata-styleguide.git"
  },
  "author": "Palantir.net, Inc. <[email protected]>",
  "license": "ISC",
  "bugs": {
    "url": "https://github.com/palantirnet/medidata-styleguide/issues"
  },
  "homepage": "https://github.com/palantirnet/medidata-styleguide#readme",
  "dependencies": {
    "butler": "git://github.com/palantirnet/butler.git#asap-404-fix"
  }
}

I get an error related to the 'ajv' module:

vagrant@medidata-styleguide:/var/www/medidata-styleguide.local$ npm install
npm WARN engine [email protected]: wanted: {"node":">=4"} (current: {"node":"0.12.18","npm":"2.15.11"})
npm WARN engine [email protected]: wanted: {"node":">=4"} (current: {"node":"0.12.18","npm":"2.15.11"})
npm WARN engine [email protected]: wanted: {"node":">=4"} (current: {"node":"0.12.18","npm":"2.15.11"})
npm WARN engine [email protected]: wanted: {"node":">= 4"} (current: {"node":"0.12.18","npm":"2.15.11"})
 
> [email protected] install /var/www/medidata-styleguide.local/node_modules/butler/node_modules/phantomjs-prebuilt
> node install.js

module.js:338
    throw err;
          ^
Error: Cannot find module 'ajv'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:278:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/var/www/medidata-styleguide.local/node_modules/butler/node_modules/har-validator/lib/node4/promise.js:30:12)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
-
> [email protected] install /var/www/medidata-styleguide.local/node_modules/butler/node_modules/node-sass
> node scripts/install.js

Cached binary found at /home/vagrant/.npm/node-sass/3.13.1/linux-x64-14_binding.node

> [email protected] postinstall /var/www/medidata-styleguide.local/node_modules/butler/node_modules/node-sass
> node scripts/build.js

Binary found at /var/www/medidata-styleguide.local/node_modules/butler/node_modules/node-sass/vendor/linux-x64-14/binding.node
Testing binary
Binary is fine
npm ERR! Linux 4.2.0-42-generic
npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "install"
npm ERR! node v0.12.18
npm ERR! npm  v2.15.11
npm ERR! code ELIFECYCLE

npm ERR! [email protected] install: `node install.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] install script 'node install.js'.
npm ERR! This is most likely a problem with the phantomjs-prebuilt package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node install.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs phantomjs-prebuilt
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! 
npm ERR!     npm owner ls phantomjs-prebuilt
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /var/www/medidata-styleguide.local/npm-debug.log

Do I need to run this with a particular version of node?

@becw becw added WIP and removed ready for review labels Oct 19, 2017
@becw
Copy link
Member

becw commented Oct 19, 2017

... and when I re-shrinkwrap myself, the branch still doesn't install in a project. This is probably happening because the drupalbox is using a pretty old version of NodeJs.

@froboy
Copy link
Contributor

froboy commented Feb 5, 2018

@becw I've had no problem installing things on UMUS using this branch, and I'm not able to use it otherwise. Could you test again to see if you get the same error as above so we can try and get this merged?

froboy added a commit that referenced this pull request Feb 5, 2018
@byrond byrond mentioned this pull request Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants