Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FS-68 add config option and template logic to move sort-by into accordion #80

Open
wants to merge 9 commits into
base: test-layout-things
Choose a base branch
from
Open

FS-68 add config option and template logic to move sort-by into accordion #80

wants to merge 9 commits into from

Conversation

nstriedinger
Copy link
Contributor

No description provided.

@biz123 biz123 changed the base branch from 3.x to test-layout-things May 28, 2020 22:16
@biz123 biz123 added the Work in-Progress Do not merge PR, currently being worked on. label May 28, 2020
@biz123
Copy link
Contributor

biz123 commented May 28, 2020

@nstriedinger I updated this to a point where it works as expected. I restored the sort menu to what it was before and now the sortFilterInAccordion setting toggles between that component as the original vs. the new one that is included in list-facet.

@biz123
Copy link
Contributor

biz123 commented May 28, 2020 •
edited
Loading

I changed the target branch to our test layout one so we can see the additions better. We should probably merge that first unless we want to review all these changes together.

@biz123 biz123 mentioned this pull request May 28, 2020
Closed
@biz123 biz123 changed the title Nothing to see here... FS-68 add config option and template logic to move sort-by into accordion May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Work in-Progress Do not merge PR, currently being worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nstriedinger @biz123