Move towards standardized project layout/setup #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove setup.py, replace with pyproject.toml * Use flit for building package/wheels * Move project logic to `src/` * Move tests to `tests/` Layout/ideas borrowed from flask-debugtoolbar
wlach
force-pushed
the
setuppy-to-pyproject-toml
branch
from
a49f47d to
449fc1d
Compare
wlach
commented
May 20, 2024
| @@ -8,11 +8,12 @@ | |||
| from unittest import mock | |||
|
|
|||
| from flask import Flask | |||
| from speaklater import make_lazy_string | |||
|
|
|||
There was a problem hiding this comment.
I think moving things to src/ made ruff realize that flask_mail was a 1st party package
wlach
commented
May 20, 2024
| description = "Flask extension for sending email" | ||
| readme = "README.md" | ||
| authors = [{ name = "Dan Jacob", email = "[email protected]" }] | ||
| maintainers = [{ name = "Pallets Ecosystem", email = "[email protected]" }] |
There was a problem hiding this comment.
Seemed to make sense to change this (modelled after flask-debugtoolbar, giving credit to the original author while making it clear who's the active maintainer)
davidism
reviewed
May 20, 2024
davidism
reviewed
May 20, 2024
davidism
reviewed
May 20, 2024
davidism
reviewed
May 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/tests/Layout/ideas borrowed from flask-debugtoolbar