wip: refactor payload processing #14589
Draft
+2,049
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
reviewed
Feb 19, 2025
| /// | ||
| /// # Transaction prewarming task | ||
| /// | ||
| /// Responsible for feeding state updates to the state root task. |
There was a problem hiding this comment.
also warming revm caches, right?
| /// | ||
| /// ## State root task | ||
| /// | ||
| /// Responsible for preparing sparse trie messages for the sparse trie task. |
There was a problem hiding this comment.
i see, so state root task will only spawn multiproofs and send results back to PayloadProcessor, but PayloadProcessor itself will send the state update + multiproof to sparse trie task?
There was a problem hiding this comment.
send results back to PayloadProcessor
send back to itself. PayloadProcessor is just some helper that spawns these 3 tasks
rkrasiuk
reviewed
Feb 19, 2025
| /// - externally cancelled (e.g. sequential block execution is complete) | ||
| /// - all transaction have been processed | ||
| /// | ||
| /// ## State root task |
There was a problem hiding this comment.
let's rename this to multiproof task?
emhane
added
C-debt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.