Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(l2-withdrawals): Verify l2 withdrawals root in PayloadValidator #14636

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feat(l2-withdrawals): Verify l2 withdrawals root in PayloadValidator #14636

wants to merge 16 commits into from
+265 −124

Conversation

emhane
Copy link
Member

@emhane emhane commented Feb 21, 2025

Closes #14583

@emhane emhane added A-engine Related to the engine implementation A-op-reth Related to Optimism and op-reth labels Feb 21, 2025
mattsse
mattsse requested changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo this is the best approach,

@rkrasiuk likely has some suggestions re improving the state access, but we can tune that separately I believe

@emhane emhane force-pushed the emhane/validate-with-hashed-state branch from 70395b1 to 0dcce05 Compare February 21, 2025 17:19
@emhane
Copy link
Member Author

emhane commented Feb 21, 2025

oh man this manifest formatting is giving me trouble on several prs now. I'm running make lint toml, and ci still doesn't like it

@emhane emhane requested a review from mattsse February 21, 2025 17:30
@emhane emhane enabled auto-merge February 21, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
A-engine Related to the engine implementation A-op-reth Related to Optimism and op-reth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify l2 withdrawals root in live sync
2 participants
@emhane @mattsse