Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct APPLIBS reference #1795

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Correct APPLIBS reference #1795

wants to merge 1 commit into from

Conversation

lbt
Copy link

@lbt lbt commented May 26, 2019 •
edited by technobly
Loading

Explain how to use APPLIBSV1 and APPLIBSV2

Problem

The docs about APPLIBS are wrong.

Solution

Fix the docs!

Steps to Test

These variables are already tested in build/test/libs.bat

References

https://community.particle.io/t/using-applibs-with-local-toolchain/35837/7

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@lbt
Correct APPLIBS reference
ff4e9c8 
Explain how to use APPLIBSV1 and APPLIBSV2
@avtolstoy avtolstoy requested a review from m-mcgowan May 29, 2019 15:53
@lbt
Copy link
Author

lbt commented Sep 24, 2019

ping

@emdash
Copy link

emdash commented Dec 13, 2019

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-mcgowan m-mcgowan m-mcgowan approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lbt @emdash @m-mcgowan @technobly