-
Notifications
You must be signed in to change notification settings - Fork 12
Adds GH Pages Workflow #69
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this automation! left two comments.
Rakefile
Outdated
version_string = `git describe --tag | cut -d "-" -f 1,2 | tr - .`.chomp | ||
if version_string.empty? | ||
version_string = '0' | ||
# Attempt to grab the date of the latest commit. If unable to, we use the current date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the Conversation note:
I updated how we retrieve the date of publication. I now do it by the last git commit date -- this ensures that when we checkout a tag, we can run it, and it gives us consistent dates.
I know we have added this to the release process but will there be a situation where the latest commit is not corresponding to a tag, i.e., changes not released yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, intentionally. So, when we automatically release to GH pages, it'll grab the tip-of-head's date. However, when we release a version, the exact commit will be tagged. Checking out that commit and running this will always give us the release date matching that of the tagged commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify further: so the page that we will see in the website is not necessarily the released version? if so, would it make sense to automate the release and as part of that publish for website?
Relevant Issues
Motivation
The PartiQL Maintainers expressed the desire to make it easier to update the specification and have more tangible impact. As a mechanism for tackling these issues, I wanted to allow the tip-of-head specification to always be rendered.
Description
gh-pages
branch.Gemfile.lock
. I ran into build issues because of this.-it
flag for running docker interactively -- this is because GH Actions doesn't allow this.Moving Forward
We will want to update how we perform releases. In my opinion, we need to update the revision numbers, tag, build on the tag, attach the generated HTML/PDF to the release assets, and update the development version.
Other Notes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.