wrapping variables in quotes for bash export (#13)

pbs · Sep 24, 2019 · 91313a3 · 91313a3
1 parent ee876d3
commit 91313a3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/internal/gorson/bash/bash.go b/internal/gorson/bash/bash.go
@@ -23,7 +23,7 @@ func ParamsToShell(parameters map[string]string) string {
 	for _, key := range keys {
 		// TODO do we need to do extra escaping here?
 		v := parameters[key]
-		lines = append(lines, "export "+key+"="+v)
+		lines = append(lines, "export "+key+"=\""+v+"\"")
 	}
 	return strings.Join(lines, "\n")
 }
diff --git a/internal/gorson/bash/bash_test.go b/internal/gorson/bash/bash_test.go
@@ -18,9 +18,9 @@ var testpairs = []testpair{
 			"beta":  "the_beta_value",
 			"delta": "the_delta_value",
 		},
-		expected: `export alpha=the_alpha_value
-export beta=the_beta_value
-export delta=the_delta_value`,
+		expected: `export alpha="the_alpha_value"
+export beta="the_beta_value"
+export delta="the_delta_value"`,
 	},
 }