CAT-23923 #56
Merged
CAT-23923 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Removed the creation of the cloudwatch log group.
socketbox
reviewed
Apr 24, 2024
There was a problem hiding this comment.
I don't understand why this 0-byte file exists at this level of the repository
There was a problem hiding this comment.
Maybe this is just kruft?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed to a more dynamic logs delivery configuration based on a list of objects, similar to the Terraform configuration.
Removed the creation of the Cloudwatch log group inside the module.
The Cloudwatch log group and the Kinesis streams should be created outside the module and referenced in the destination by their name.