Adding mysql to engine_version validation #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation we had was only valid for PostgreSQL and as a result prevented MySQL clusters from upgrading to the latest version of this module because their version string is formatted different (8.0.mysql_aurora.3.07.0 for example). I think it would be pretty tough to validate this field. For your consideration, consider the output of `aws rds describe-db-engine-versions`. At the time of writing, running this command gives 154 options for mysql and postgres alone. Given that terragrunt apply would catch this for us, I don't think it's really worth trying to validate against so many options.
chipbell4
commented
Mar 3, 2025
| @@ -53,7 +53,7 @@ variable "engine_mode" { | |||
| default = "provisioned" | |||
| type = string | |||
| validation { | |||
| condition = var.engine_mode == "provisioned" || var.engine_mode == "serverless" | |||
| condition = (var.engine_mode == "provisioned" || var.engine_mode == "serverless") | |||
There was a problem hiding this comment.
terraform fmt made this update.
chipbell4
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation we had was only valid for PostgreSQL and as a result prevented MySQL clusters from upgrading to the latest version of this module because their version string is formatted different (8.0.mysql_aurora.3.07.0 for example).
I think it would be pretty tough to validate this field. For your consideration, consider the output of
aws rds describe-db-engine-versions. At the time of writing, running this command gives 154 options for mysql and postgres alone. Given that terragrunt apply would catch this for us, I don't think it's really worth trying to validate against so many options.