Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 202409 #100

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Support 202409 #100

merged 1 commit into from
Oct 18, 2024

Conversation

vegu
Copy link
Contributor

@vegu vegu commented Oct 7, 2024

fixes #95

Make client more robust when dealing with errors. #95
@vegu vegu requested a review from grizz October 7, 2024 12:38
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 51.13636% with 43 lines in your changes missing coverage. Please review.

Project coverage is 81.22%. Comparing base (a3d61b3) to head (025b1a4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/peeringdb/commands.py 28.00% 18 Missing ⚠️
src/peeringdb/util.py 54.28% 16 Missing ⚠️
src/peeringdb/_update.py 64.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   82.52%   81.22%   -1.31%     
==========================================
  Files          16       16              
  Lines        1116     1177      +61     
==========================================
+ Hits          921      956      +35     
- Misses        195      221      +26     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grizz grizz merged commit 590404e into master Oct 18, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make client more robust when dealing with api errors.
3 participants