Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health frontend route #776

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Health frontend route #776

wants to merge 9 commits into from

Conversation

sritanmotati
Copy link
Contributor

/health route

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.67%. Comparing base (ec1f642) to head (533a02e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #776   +/-   ##
=======================================
  Coverage   72.67%   72.67%           
=======================================
  Files          32       32           
  Lines        7078     7078           
=======================================
  Hits         5144     5144           
  Misses       1934     1934           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@julianweng julianweng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for taking the initiative on this, can you split this PR into multiple if you intend on doing all of these things (editing OSA cronjob time, non-health related prettier changes, and health): would like to keep this focused on just health.

Copy link
Member

@aviupadhyayula aviupadhyayula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the initiative on this! Agree with Julian that it'd be nice to break this up into separate PRs -- feel free to remove the k8s changes and just push those to another branch.

k8s/main.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants