-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Health frontend route #776
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #776 +/- ##
=======================================
Coverage 72.67% 72.67%
=======================================
Files 32 32
Lines 7078 7078
=======================================
Hits 5144 5144
Misses 1934 1934 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for taking the initiative on this, can you split this PR into multiple if you intend on doing all of these things (editing OSA cronjob time, non-health related prettier changes, and health): would like to keep this focused on just health.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the initiative on this! Agree with Julian that it'd be nice to break this up into separate PRs -- feel free to remove the k8s
changes and just push those to another branch.
This reverts commit f61a9eb.
/health route