PMM-10369 implement websockets notifications for checks #477

filipmikes1 · 2022-08-05T13:51:07Z

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

* PMM-7528 Don't show db cluster list error * PMM-7528 Disable DBCluster tab when no cluster is available

Co-authored-by: Nicola Lamacchia <[email protected]>

* PMM-8127 Request DB clusters when even if operator is unsupported * PMM-8127 Refactor operator status

* PMM-8135: uncomment backup feature * PMM-8135 remove disabled attrib from backup toggle Co-authored-by: Nicola Lamacchia <[email protected]>

* PMM-8115 Trigger table loading on db cluster delete * PMM-8115 Refactor useDBClusters return type Co-authored-by: Nicola Lamacchia <[email protected]>

Co-authored-by: Nicola Lamacchia <[email protected]>

* PMM-8143 add force fields to DeleteModal * PMM-8143 add force checkbox using Form * PMM-8143 add tests related do force checkbox * PMM-8143 use DeleteModal on DBaaS * PMM-8143 use DeleteModal on Agent list * PMM-8143 fix test on StorageLocations * PMM-8143 add data-qa attribs to buttons * PMM-8143 change confirm button text on Agents * Revert "PMM-8143 use DeleteModal on DBaaS" This reverts commit 2d7dccf. * Revert "PMM-8143 use DeleteModal on Agent list" This reverts commit cb80f1e. * PMM-8143 remove outdated TODO

* PMM-8153 add noService prop * PMM-8153 add "no service" error * PMM-8153 add data-qa to error line * PMM-8153 add tests to RestoreBackupModal

* PMM-8009 Add maxLength validator * PMM-8009 Add name length validation in sign up * PMM-8009 Fix test name wording

* SAAS-554 make target for launching PMM, docker-compose.yml with dev-latest, UI tests workflow * SAAS-554 fixes for workflow * SAAS-554 change organization for pmm-ui-tests * SAAS-554 use cache fix * SAAS-554 attaching articacts * SAAS-554 tesing with @grafana-pr tag * SAAS-554 timeout for the workflow and other tweaks * SAAS-554 fix startup * SAAS-554 checkout non main tests branch if exists * SAAS-554 added mysql into docker-compose.yml, removed unused ports, using npm script for starting tests * SAAS-554 Update comment in Makefile Co-authored-by: Alex Tymchuk <[email protected]> * SAAS-554 using martix strategy for a workflow Co-authored-by: Nicola Lamacchia <[email protected]> Co-authored-by: Alex Tymchuk <[email protected]>

* PMM-6627 trim input fields * PMM-6627 fix email validator * PMM-6627 update tests

* PMM-7828 Selects database type for installed operator * PMM-7828 Removed unused import

…iting for BE) (#156) * PMM-7639: add force checkbox * PMM-7639 add checkbox test to modal * PMM-7639 fix StorageLocations test * PMM-7639 move "Force" label to messages file * PMM-7639 use showForce from DeleteModal Co-authored-by: Nicola Lamacchia <[email protected]>

* PMM-7659 Add external access to DB cluster * PMM-7659 Use dataQa

* PMM-7649 Show unauthorized messaged in FeatureLoader * PMM-7649 FeatureLoader tests * PMM-7649 Change unauthorized message * PMM-7649 Use getMount * PMM-7649 Add instance, inventory and settings * PMM-7649 Remove admin required from backups * PMM-7649 Remove unused pmm admin

Co-authored-by: Tiago Mota Santos <[email protected]> Co-authored-by: JiriCtvrtka <[email protected]>

Co-authored-by: Nicola Lamacchia <[email protected]>

* PMM-7809 Fix yarn cache * PMM-7809 Temp clear yarn cache

* PMM-10351-DBaaS-naming-update: fix naming and layout * PMM-10351-DBaaS-naming-update: code-review fix * PMM-10351-DBaaS-naming-update: code-review fix * PMM-10351-DBaaS-naming-update: fix yarn.lock * PMM-10351-DBaaS-naming-update: fix types * PMM-10340 update lockfile * PMM-10351-DBaaS-naming-update: fix tests id Co-authored-by: Fabio Silva <[email protected]>

* PMM-10368 change warning for dbaas * PMM-10368 add warning to platform connection * PMM-10368 fix loading status for dbcluster * PMM-10368 fix test for Connect * PMM-10368 add types to file * PMM-10368 fix tests * PMM-10368 fix flows * PMM-10368 fix test * PMM-10368 fix plural for dbCluster * PMM-10368 add custom useShowPMMAddressWarning * PMM-10368 fix tests * PMM-10368 add missing provider to test * PMM-10368 add missing Router to tests

* PMM-10327-promote-portal-k8s-cluster-creation: message added * PMM-10327-promote-portal-k8s-cluster-creation: fix link Co-authored-by: Fábio Silva <[email protected]>

fabio-silva · 2022-08-08T09:48:30Z

public/app/percona/shared/websockets/notifications.ts

+      }
+
+      if (
+        Severity[value.severity] === Severity.SEVERITY_ALERT ||


can we use a switch instead?

fabio-silva · 2022-08-08T09:49:33Z

public/app/percona/shared/websockets/notifications.types.ts

+        description: string;
+        severity: keyof typeof Severity;
+        labels: {
+          additionalProp1: string;


I think these are just examples, we probably want labels: {[key: string]: string | number}

hmm I already changed it but didn't push it for some reason...corrected

…ithub.com/percona-platform/grafana into PMM-10369-implement-websockets-for-checks

public/app/percona/shared/websockets/notifications.ts

…468) * PMM-10182-One-Button-Database-Deployment: add defaultValues to form * PMM-10182-One-Button-Database-Deployment: fix tests * PMM-10182-One-Button-Database-Deployment: fix database type initial options * PMM-10182-One-Button-Database-Deployment: remove extra comments * PMM-10182-One-Button-Database-Deployment: return old yarn lock * PMM-10182-One-Button-Database-Deployment: fix tests * PMM-10182-One-Button-Database-Deployment: code review fix

* PMM-10119: Implement displaying datapoint summaries * Update public/app/percona/settings/Settings.messages.ts Co-authored-by: Fábio Silva <[email protected]> * PMM-10119: Create separate component TelemetryTooltip * PMM-10119: Refactor LinkTooltip component * PMM-10119: Update style for list with summaries * PMM-10119: Rename property * PMM-10119: Make tooltip with summaries of datapoints scrollable Co-authored-by: Fábio Silva <[email protected]>

tiagomotasantos and others added 30 commits February 10, 2022 11:47

PMM-7528 Hide DB cluster list error (#150)

54e8a04

* PMM-7528 Don't show db cluster list error * PMM-7528 Disable DBCluster tab when no cluster is available

PMM-7755 Validate cluster name length (#151)

176f7c5

Co-authored-by: Nicola Lamacchia <[email protected]>

PMM-8127 Request DB clusters even if operator is unsupported (#159)

6f5b174

* PMM-8127 Request DB clusters when even if operator is unsupported * PMM-8127 Refactor operator status

PMM-8135: enable backup feature (#158)

15d76c7

* PMM-8135: uncomment backup feature * PMM-8135 remove disabled attrib from backup toggle Co-authored-by: Nicola Lamacchia <[email protected]>

PMM-8115 Trigger table loading on db cluster delete (#157)

6fa92e8

* PMM-8115 Trigger table loading on db cluster delete * PMM-8115 Refactor useDBClusters return type Co-authored-by: Nicola Lamacchia <[email protected]>

PMM-8021 Fix QAN menu typo (#155)

b39552c

Co-authored-by: Nicola Lamacchia <[email protected]>

PMM-7970 Fix cluster message (#153)

6b1ecf0

PMM-8153: block restore when there is no service (#161)

0bf90b0

* PMM-8153 add noService prop * PMM-8153 add "no service" error * PMM-8153 add data-qa to error line * PMM-8153 add tests to RestoreBackupModal

PMM-8009 add signup name validation (#134)

31a565e

* PMM-8009 Add maxLength validator * PMM-8009 Add name length validation in sign up * PMM-8009 Fix test name wording

Fix prettier and build

6db52e0

Fix lint errors

c41c364

Fix go errors

d087de1

Skip tests

954e2c6

Update dependencies

b5134a6

PMM-7809 Update node to version 14

4b892fe

PMM-6627 trim inputs (#148)

175c181

* PMM-6627 trim input fields * PMM-6627 fix email validator * PMM-6627 update tests

PMM-7828 Selects database type for installed operator (#162)

6905d55

* PMM-7828 Selects database type for installed operator * PMM-7828 Removed unused import

PMM-7659 Add external access to DB cluster (#172)

2c16a6a

* PMM-7659 Add external access to DB cluster * PMM-7659 Use dataQa

PMM-7809 Update to latest chnages

ab1cded

PMM-7809 Update node in ui tests

d23f70f

PMM-7809 Remove jest from test-percona script

14e3118

PMM-7809 Unit tests CI

723e9bf

PMM-7690 iam roles (#147)

4394d4f

Co-authored-by: Tiago Mota Santos <[email protected]> Co-authored-by: JiriCtvrtka <[email protected]>

PMM-8299 add missing return on delete (#174)

6a82883

Co-authored-by: Nicola Lamacchia <[email protected]>

PMM-7809 Update core-ui version

aed864e

PMM-7809 Clean yarn cache (#186)

d5876ec

* PMM-7809 Fix yarn cache * PMM-7809 Temp clear yarn cache

filipmikes1 and others added 8 commits July 29, 2022 10:08

PMM-10369 Improved websocket reconnection

2a3321e

PMM-10369 added JSON stringify

852784b

PMM-10369 add websocket only for logged user

546e23a

PMM-10369 merge main

c3a981e

PMM-10369 improved logic, added done notif.

aca70f1

PMM-10369 Added new field to object

19c6882

Merge branch 'main' into PMM-10369-implement-websockets-for-checks

00b7138

filipmikes1 requested a review from fabio-silva August 5, 2022 13:53

fabio-silva and others added 3 commits August 5, 2022 15:08

PMM-10327 promote portal k8s cluster creation message (#470)

6d60076

* PMM-10327-promote-portal-k8s-cluster-creation: message added * PMM-10327-promote-portal-k8s-cluster-creation: fix link Co-authored-by: Fábio Silva <[email protected]>

Merge branch 'main' into PMM-10369-implement-websockets-for-checks

c98d9d0

fabio-silva marked this pull request as ready for review August 8, 2022 09:28

fabio-silva requested changes Aug 8, 2022

View reviewed changes

filipmikes1 added 2 commits August 8, 2022 13:14

PMM-10369 Added switch, improved check obj

238a24b

Merge branch 'PMM-10369-implement-websockets-for-checks' of https://g…

61415eb

…ithub.com/percona-platform/grafana into PMM-10369-implement-websockets-for-checks

filipmikes1 requested a review from fabio-silva August 8, 2022 11:17

fabio-silva requested changes Aug 8, 2022

View reviewed changes

public/app/percona/shared/websockets/notifications.ts Outdated Show resolved Hide resolved

PMM-10369 fixed switch statement

8a5d270

filipmikes1 requested a review from fabio-silva August 8, 2022 12:47

matejkubinec and others added 3 commits August 8, 2022 16:02

PMM-10076 enable date range submit by hitting enter (#458)

0576cd7

PMM-10474 disable notifs for saasHost (#475)

2326938

Merge branch 'main' into PMM-10369-implement-websockets-for-checks

11c5764

fabio-silva previously approved these changes Aug 8, 2022

View reviewed changes

solovevayaroslavna and others added 4 commits August 9, 2022 12:32

Merge branch 'main' into PMM-10369-implement-websockets-for-checks

094e7b7

Merge branch 'main' into PMM-10369-implement-websockets-for-checks

f2a6ae4

fabio-silva force-pushed the main branch from 119bcdf to 2680b34 Compare September 9, 2022 11:17

matejkubinec dismissed fabio-silva’s stale review via f2a6ae4 September 23, 2022 10:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PMM-10369 implement websockets notifications for checks #477

PMM-10369 implement websockets notifications for checks #477

filipmikes1 commented Aug 5, 2022

fabio-silva Aug 8, 2022 •

edited

Loading

filipmikes1 Aug 8, 2022

fabio-silva Aug 8, 2022

filipmikes1 Aug 8, 2022

PMM-10369 implement websockets notifications for checks #477

Are you sure you want to change the base?

PMM-10369 implement websockets notifications for checks #477

Conversation

filipmikes1 commented Aug 5, 2022

fabio-silva Aug 8, 2022 • edited Loading

Choose a reason for hiding this comment

filipmikes1 Aug 8, 2022

Choose a reason for hiding this comment

fabio-silva Aug 8, 2022

Choose a reason for hiding this comment

filipmikes1 Aug 8, 2022

Choose a reason for hiding this comment

fabio-silva Aug 8, 2022 •

edited

Loading