Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PT-2422 Fix unconstrained UPDATE to pt_osc_history table #918

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from
Open

PT-2422 Fix unconstrained UPDATE to pt_osc_history table #918

wants to merge 1 commit into from

Conversation

drwonky
Copy link

@drwonky drwonky commented Jan 28, 2025 •
edited
Loading

  • The contributed code is licensed under GPL v2.0
  • Contributor Licence Agreement (CLA) is signed
  • util/update-modules has been ran
  • Documentation updated
  • Test suite update

@it-percona-cla
Copy link

it-percona-cla commented Jan 28, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@drwonky
Copy link
Author

drwonky commented Jan 28, 2025 •
edited
Loading

This needs a proper test, I am unable to run the test suite and I'm not especially familiar with this test format. The requirements for the test are as follows:

  • Create 2 or more databases with the same schema
  • Create a differing number of _tablename_new,__tablename_new, ___tablename_new tables in each database
  • Launch 1 pt-osc instance
  • Wait 1 or more seconds
  • Launch 1 or more additional pt-osc instances, one per database each modifying tablename
  • Observe the percona.pt_osc_history table and ensure that each unique invocation of pt-osc modifies exactly 1 history table job entry (there should be 1 unique new_table_name for each parallel invocation of pt-osc)

@drwonky
PT-2422 Fix unconstrained UPDATE to pt_osc_history table
9e9f743 
Ensure that entries in the history table are updated by job_id
instead of updating ALL instances of jobs in the history table.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svetasmirnova svetasmirnova Awaiting requested review from svetasmirnova svetasmirnova is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drwonky @it-percona-cla