Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separated files for directory file-entities #218

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

alfsb
Copy link
Member

@alfsb alfsb commented Feb 6, 2025

This PR partially reverts #213 , re-enabling the creation of separated files for directory file-entities.

Per documentation, LIBXML_PARSEHUGE:

Sets XML_PARSE_HUGE flag, which relaxes any hardcoded limit from the parser. This affects limits like maximum depth of a document or the entity recursion, as well as limits of the size of text nodes.

Even being a very old option (since libxml 2.7.0 / PHP 5.3 eras), it is insufficient for PHP manual building, in some OS and libxml versions. Until there is something like a truly LIBXML_PARSEUNLIMITED, PHP Manuals will soon become unparseable.

@alfsb
Copy link
Member Author

alfsb commented Feb 6, 2025

@leonardolara , please test this. I think it may fix the Maximum entity amplification factor exceeded error.

As side note, as Portuguese language is more verbose than English, the pt_BR manual is particularly susceptible to the "entity amplification" error:

@leonardolara
Copy link
Contributor

@leonardolara , please test this. I think it may fix the Maximum entity amplification factor exceeded error.

As side note, as Portuguese language is more verbose than English, the pt_BR manual is particularly susceptible to the "entity amplification" error:

Ok, now it's building again. Nice work!

@alfsb
Copy link
Member Author

alfsb commented Feb 6, 2025

Nice to hear that. I will try test this on Windows, before merging it. Testing by other people would be nice, too, as this is an intermitent error, that only occurs in some PHP/libxml versions.

@alfsb
Copy link
Member Author

alfsb commented Feb 7, 2025

Local tested on Win 10, PHP 8.3.14. Merging.

@alfsb alfsb merged commit 0ae92dd into php:master Feb 7, 2025
8 of 12 checks passed
@alfsb alfsb deleted the rv5 branch February 7, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants