docs: add macos instruction, update blocks, misc changes #17642
Conversation
| # ------------------------------------------------------------------------------ | ||
| # Intellij IDEA configuration directory | ||
| # ------------------------------------------------------------------------------ | ||
| /.idea |
There was a problem hiding this comment.
This belongs in your personal gitignore.
There was a problem hiding this comment.
I like how people do various smart functions and then say it's not needed now.
I have a project with commited .idea folder, I cannot mark it globally ignored.
Otherwise one line is not a problem for any project.
Moreover there are about 300 lines with long comments.
And one more thing is gitignore already has definitions for some tools like this:
# Backup copies created by various editors or development tools
*~
vim? IDEA doesn't create such files
There was a problem hiding this comment.
It's not a problem to remove it and keep .idea changes separately from current changes, but it's not convenient as for me
There was a problem hiding this comment.
I have a project with commited .idea folder, I cannot mark it globally ignored.
You can use git add -f .idea if you want to add a file that's globally ignored.
There was a problem hiding this comment.
Also, you do have the option to ignore it locally, for only the current .git repo, by adding it to .git/info/exclude.
There was a problem hiding this comment.
Although we have *.swp and mentioned *~ in the .gitignore. Personally I wouldn't really mind having various editors in .gitignore but don't really care that much as I have it in .git/info/exclude...
There was a problem hiding this comment.
I don't mind adding IDEs to the exclude file, but we should add all common ones then. At least .vscode, possibly Visual Studio (not sure what files it creates). Newer ones include .zed and .fleet, although they are more conservative about creating these directories (only on-demand).
There was a problem hiding this comment.
Yeah I got
.idea/
.vscode/
so might make sense to add those. Should be probably a different PR as we shouldn't mix unrelated things together.
|
|
||
| Build PHP. To speed up the build, specify the maximum number of jobs using `-j`: | ||
|
|
||
| make -j4 | ||
| ```shell | ||
| make -j$(nproc) |
There was a problem hiding this comment.
This is unix(-like) specific. We should either specify other operating systems or keep the original 4.
| Use `TESTS` variable to tests only specific directories: | ||
|
|
||
| ```shell | ||
| make TESTS=Zend/tests/throw/ test |
There was a problem hiding this comment.
You can also use TEST_PHP_ARGS for that. TEST_PHP_ARGS is an env variable while TESTS is passed as a shell argument. I'm not sure why both of these exist. Maybe @petk knows.
| On MacOS, you can install these using: | ||
|
|
||
| ```shell | ||
| brew install autoconf bison re2c iconv |
There was a problem hiding this comment.
Is this enough for a default build with no arguments? E.g. libxml2 might be needed for ext-xml.
There was a problem hiding this comment.
Just tried to install all of this for the first time and it failed. Tried to install only these and configure and make succeeded
No description provided.