Skip to content

Commit

Permalink
Only pass GITHUB_TOKEN to steps that actually need it
Browse files Browse the repository at this point in the history
  • Loading branch information
asgrim committed Jan 14, 2025
1 parent c514bb0 commit 10a7299
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ permissions:
jobs:
unit-tests:
runs-on: ${{ matrix.operating-system }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
strategy:
matrix:
operating-system:
Expand All @@ -28,6 +26,8 @@ jobs:
with:
php-version: ${{ matrix.php-versions }}
extensions: intl, sodium, zip
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- uses: actions/checkout@v4
# temporarily remove Psalm until ready for PHP 8.4
- name: remove psalm
Expand All @@ -37,9 +37,13 @@ jobs:
- name: Run PHPUnit on Windows
if: matrix.operating-system == 'windows-latest'
run: vendor/bin/phpunit
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Run PHPUnit on non-Windows
if: matrix.operating-system != 'windows-latest'
run: sudo vendor/bin/phpunit
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

behaviour-tests:
runs-on: ${{ matrix.operating-system }}
Expand Down

0 comments on commit 10a7299

Please sign in to comment.