Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Psalm 6.x #181

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Update to Psalm 6.x #181

merged 4 commits into from
Jan 29, 2025

Conversation

TimWolla
Copy link
Member

Opted to baseline the newly reported errors for now. Properly “fixing” those will likely result in tons of assert() calls being added.

@TimWolla
Update psalm/plugin-phpunit to 0.19.1
e861157
@TimWolla
Update to Psalm 6.x
32f78c2 
Update performed with `composer update vimeo/psalm -w -m` to make the minimal
number of changes necessary in composer.json.
@GromNaN
Copy link
Member

GromNaN commented Jan 29, 2025 •
edited
Loading

You should set ignoreInternalFunctionFalseReturn to true. The functions that return false in case of failure also trigger a warning, that is converted to an ErrorException by the error handler (provided by Symfony Console or PHPUnit). So they never return in case of failure.

@asgrim asgrim self-assigned this Jan 29, 2025
@asgrim asgrim added the enhancement New feature or request label Jan 29, 2025
@asgrim asgrim added this to the 0.7.0 milestone Jan 29, 2025
@asgrim asgrim merged commit 22f0187 into php:main Jan 29, 2025
19 checks passed
@asgrim
Copy link
Collaborator

asgrim commented Jan 29, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN approved these changes

@asgrim asgrim asgrim approved these changes

Assignees

@asgrim asgrim

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@TimWolla @GromNaN @asgrim