Allow extensions to override download URLs #187
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 4, 2025
Draft
asgrim
commented
Feb 4, 2025
test/unit/ComposerIntegration/Listeners/OverrideDownloadUrlInstallListenerTest.php
Outdated
Show resolved
Hide resolved
asgrim
commented
Feb 4, 2025
stof
reviewed
Feb 5, 2025
Co-authored-by: Christophe Coevoet <[email protected]>
asgrim
force-pushed
the
override-source-download-urls
branch
from
ba9c76b to
36da7b2
Compare
TimWolla
reviewed
Feb 5, 2025
asgrim
force-pushed
the
override-source-download-urls
branch
from
6af069d to
70639a7
Compare
asgrim
commented
Feb 6, 2025
| @@ -28,7 +28,7 @@ | |||
| ], | |||
| "require": { | |||
| "php": "8.1.*||8.2.*||8.3.*||8.4.*", | |||
| "composer/composer": "^2.8.5", | |||
| "composer/composer": "dev-main", | |||
There was a problem hiding this comment.
We should probably pin to the next stable Composer release, when that happens 👍
There was a problem hiding this comment.
I suggest using ^2.9.0@dev instead as constraint here. It will be more explicit about the intent
GromNaN
reviewed
Feb 7, 2025
Comment on lines
+163
to
+167
| The `build-path` may contain some templated values which are replaced: | ||
|
|
||
| * `{version}` to be replaced with the package version. For example a package | ||
| with version 1.2.3 with a `build-path` of `myext-{version}` the actual build | ||
| path would become `myext-1.2.3`. |
There was a problem hiding this comment.
The build-path could be detected: if the root directory doesn't contain a configure file but there is a single directory that contains this file, then go into it.
For the mongodb extension, the build-path is at the root of the Git repository, so this setting seems incompatible with installation from Git clone.
There was a problem hiding this comment.
Good idea! Leave it with me and I'll see what we can do, thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39