Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the regexp used for matching #329

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ex1st
Copy link

@ex1st ex1st commented Sep 21, 2024

This is an attempt to return the functionality to build a routers tree for express app.
Developers can replace layer.regexp by layer.matchers[0].regexp in original code from @dougwilson expressjs/express#5858 (comment)

expressjs/express#5961

@blakeembrey
Copy link
Member

While this can be added I’d rather not add it for this reason. I think you’d be better off describing what you actually want as a feature and working on getting that added officially, since that code feels like it could break any time the regex changes and I don’t understand how it would work properly for all the different features of path-to-regexp.

What is it you actually want from Express?

@ex1st
Copy link
Author

ex1st commented Sep 25, 2024

Hi @blakeembrey, if pillarjs/router#123 will be merged, i will close it.

What is it you actually want from Express?

List of routes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants