-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sourcemanager(ticdc): close all pullers asyncrhonsly to prevent block too long #11667
base: release-6.5
Are you sure you want to change the base?
sourcemanager(ticdc): close all pullers asyncrhonsly to prevent block too long #11667
Conversation
/retest |
6b1e6ee
to
0dee538
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
What problem does this PR solve?
Issue Number: close #11638
What is changed and how it works?
Before this PR, all pullers close in order, one by one, each takes around 0.03 ~ 0.05s, if there are a lot of tables, it would takes a long time.
The following log shows that close 1000 tables takes 50 seconds.
After the PR, the time cost is depend on the slowest table puller, around 0 ~ 2 seconds.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note