-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checker(dm): update gtidSet by checkpoint data in MetaPositionChecker #11668
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @fishiu. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11668 +/- ##
================================================
- Coverage 55.2441% 55.1497% -0.0945%
================================================
Files 1001 1001
Lines 136237 136483 +246
================================================
+ Hits 75263 75270 +7
- Misses 55486 55704 +218
- Partials 5488 5509 +21 |
/retest |
2 similar comments
/retest |
/retest |
/retest |
@fishiu: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #11648
What is changed and how it works?
In MetaPositionChecker (GTID enabled), we used to compare only the GTID from config file with the upstream binlog. However when we restart with the same config, the GTID info from config might be outdated (e.g. old binlogs are purgeded), while the updated one is saved in checkpoint.
Now in MetaPositionChecker stage, we load checkpoint data from downstream db, and replace the GTID from config if it is outdated.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note