Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checker(dm): update gtidSet by checkpoint data in MetaPositionChecker #11668

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fishiu
Copy link
Contributor

@fishiu fishiu commented Oct 17, 2024

What problem does this PR solve?

Issue Number: close #11648

What is changed and how it works?

In MetaPositionChecker (GTID enabled), we used to compare only the GTID from config file with the upstream binlog. However when we restart with the same config, the GTID info from config might be outdated (e.g. old binlogs are purgeded), while the updated one is saved in checkpoint.

Now in MetaPositionChecker stage, we load checkpoint data from downstream db, and replace the GTID from config if it is outdated.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 17, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign d3hunter for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added area/dm Issues or PRs related to DM. contribution This PR is from a community contributor. labels Oct 17, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 17, 2024

Hi @fishiu. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2024
@fishiu fishiu changed the title checker(dm): update gtidset by checkpoint info in MetaPositionChecker checker(dm): update gtidSet by checkpoint info in MetaPositionChecker Oct 17, 2024
@fishiu fishiu changed the title checker(dm): update gtidSet by checkpoint info in MetaPositionChecker checker(dm): update gtidSet by checkpoint information in MetaPositionChecker Oct 17, 2024
@fishiu fishiu changed the title checker(dm): update gtidSet by checkpoint information in MetaPositionChecker checker(dm): update gtidSet by checkpoint data in MetaPositionChecker Oct 17, 2024
@lance6716
Copy link
Contributor

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 55.1497%. Comparing base (62d07b5) to head (2d1bdd4).
Report is 1 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 59.6317% <ø> (-0.1970%) ⬇️
dm 50.0510% <0.0000%> (-0.0030%) ⬇️
engine 53.1997% <ø> (-0.0339%) ⬇️
Flag Coverage Δ
unit 55.1497% <0.0000%> (-0.0945%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11668        +/-   ##
================================================
- Coverage   55.2441%   55.1497%   -0.0945%     
================================================
  Files          1001       1001                
  Lines        136237     136483       +246     
================================================
+ Hits          75263      75270         +7     
- Misses        55486      55704       +218     
- Partials       5488       5509        +21     

@fishiu
Copy link
Contributor Author

fishiu commented Oct 17, 2024

/retest

2 similar comments
@fishiu
Copy link
Contributor Author

fishiu commented Oct 17, 2024

/retest

@fishiu
Copy link
Contributor Author

fishiu commented Oct 17, 2024

/retest

@fishiu
Copy link
Contributor Author

fishiu commented Oct 22, 2024

/retest

Copy link
Contributor

ti-chi-bot bot commented Oct 22, 2024

@fishiu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-dm-integration-test 2d1bdd4 link true /test dm-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. contribution This PR is from a community contributor. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DM precheck failed to check GTID when stop and then start from checkpoint with same task config
2 participants