-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a stand-alone load mode to DM. #11749
base: master
Are you sure you want to change the base?
Conversation
not be needed anymore and could be depreciated in the future.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11749 +/- ##
================================================
+ Coverage 53.2223% 55.1517% +1.9293%
================================================
Files 213 1002 +789
Lines 17720 137401 +119681
================================================
+ Hits 9431 75779 +66348
- Misses 7686 56075 +48389
- Partials 603 5547 +4944 |
/test engine-integration-test |
/test dm-integration-test |
d239bf5
to
aacf64d
Compare
/retest |
run_dm_ctl_with_retry $WORK_DIR "127.0.0.1:$MASTER_PORT" \ | ||
"query-status $task_name_load" 100 \ | ||
"\"stage\": \"Finished\"" 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about adding the sync task after load task finish? For test the complete create DM task
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can definitely do that. I actually have a test written in E2E, which I'll submit in a separate PR. How about I also add that test to the OpenAPI test suite along with the E2E PR? Additionally, we could merge the dump test with the existing load test, as the load test above already covers the dump task.
What problem does this PR solve?
Issue Number: close #9230
What is changed and how it works?
Primary work to add a stand-alone load mode to DM, alongside with dump mode. Load&Sync mode might not be needed anymore and could be depreciated in the future.
UT/IT added are under testing and will be pushed soon.
Continue the work from #11738 as its intended change in openapi conflicted with that of #11729.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
N/A
Do you need to update user documentation, design documentation or monitoring documentation?
Yes. Description of those standalone modes would need to be added to docs for openapi only. Support for dmctl will be delayed further.
Release note