Parse Candidate Extensions (RFC5245)

[JoeTurki]

Description

• Rewrote UnmarshalCandidate to better align with RFC5245.
• Added new methods for extracting candidate extensions.
• Updated Equal and Marshal to accommodate these changes.
• Added tests for everything.
• Fixed a "bug" where tcptype would appear before raddr .
• Made a minor change to gather.go; because we can't use the config struct as a map key anymore.
• Added CandidateExtension.

I'm aware this is a breaking change but this change is required for many issues like pion/webrtc#2993

Edit: I'll make it non breaking change tomorrow.

Reference issue

#753

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.01%. Comparing base (abdc0ca) to head (ab6e243).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #754      +/-   ##
==========================================
+ Coverage   78.63%   80.01%   +1.37%     
==========================================
  Files          41       41              
  Lines        4769     5023     +254     
==========================================
+ Hits         3750     4019     +269     
+ Misses        785      775      -10     
+ Partials      234      229       -5     

Flag	Coverage Δ
go	80.01% <100.00%> (+1.37%)	⬆️
wasm	27.89% <100.00%> (+4.79%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nils-ohlmeier]

Just a few minor suggestions. But looks good otherwise.

[Sean-Der]

Nice, love these improvements :)

Glad we can do this without API break. It means people don’t update and new versions don’t get improved :(

[JoeTurki]

I added CandidateExtensions and CandidateExtension, And fixed all the other issues.

@Sean-Der @nils-ohlmeier let me know if there are other problems :)

Thanks.

[nils-ohlmeier]

Looks good to me.

[Sean-Der]

Fantastic! This is great.

Sorry about the stress of APIs. It’s just so hard to fix them. We can always fix/improve code though.

Its nice to expose as little as possible until someone requests it :)

[JoeTurki]

@Sean-Der When you have a time can you take a look.

Sorry about the stress of APIs. It’s just so hard to fix them. We can always fix/improve code though.

It's not stressing at all for me :)

Its nice to expose as little as possible until someone requests it :)

This makes sense, Noted :)

[Sean-Der]

@JoeTurki sorry one last change to keep return types consistent. After that merge it! If we do have bugs/improvements to make we call roll forward :)

sorry for all the rounds on this.

[Sean-Der]

no need to wait for another approval for me

[JoeTurki]

@Sean-Der
Hopefully, this is my first API change of many :)

I now have a better understanding of how changes are made to the Pion API, I'll take all feedback into consideration to try to make future iterations shorter.

Thanks!