Fix test_http.request_callback #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddelange
force-pushed
the
patch-5
branch
4 times, most recently
from
f4bac24
to
a874df5
Compare
3 tasks
ddelange
force-pushed
the
patch-5
branch
12 times, most recently
from
5671d0e
to
9e6f31c
Compare
|
with the new python versions in the test matrix, ssl in integration test started complaining about ftps server's self-signed cert so i explicitly created a self-signed cert for localhost and passed it in the integration test. but now there's and i'm not sure how to proceed. |
|
|
|
got it, we're green now:) rsa_cert_file=/etc/vsftpd.pem
+ rsa_private_key_file=/etc/vsftpd.key |
ddelange
force-pushed
the
patch-5
branch
2 times, most recently
from
8bdd9d3
to
bfb9f93
Compare
|
@mpenkov please review |
ddelange
commented
Aug 9, 2024
| from functools import partial | ||
|
|
||
| # localhost has self-signed cert, see ci_helpers/helpers.sh:create_ftp_ftps_servers | ||
| ssl.create_default_context = partial(ssl.create_default_context, cafile="/etc/vsftpd.pem") |
There was a problem hiding this comment.
probably worth moving to transport_params in a separate PR https://docs.python.org/3/library/ssl.html#ssl.create_default_context
5 tasks
|
LGTM, thank you! |
ddelange
added a commit
to ddelange/smart_open
that referenced
this pull request
Aug 15, 2024
…open into zstd-ab-error * 'develop' of https://github.com/RaRe-Technologies/smart_open: Fix test_http.request_callback (piskvorky#828)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Fix tests with urllib3 v2
Motivation
Fix #784, CI was running only 3.7 (hence urllib3 v1) due to a typo regarding
python-version.Tests
Fix sftp tests now that CI is running python 3.8--3.12
Work in progress
Checklist
Before you create the PR, please make sure you have:
Workflow
Please avoid rebasing and force-pushing to the branch of the PR once a review is in progress.
Rebasing can make your commits look a bit cleaner, but it also makes life more difficult from the reviewer, because they are no longer able to distinguish between code that has already been reviewed, and unreviewed code.