A11y/modals #16
Open
A11y/modals #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re initial a11y info
…re initial a11y info
…set focus back to trigger on modal close
…n close if exists
|
@brandonkelly this is nearly there, but I'd like to test on an instance (if there is one) where two modals are visible at once to ensure the ariaHide function is working properly. |
…se in other components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aims to fix a few accessibility issues with modals, including the following:
aria-hidden="true"on all sibling elements in the body (not includingstyleorscripttags)triggerElementsetting to store default element to refocus on closeThis is being worked on consecutively with updates in the CMS repo
Related issues
CMS-009, CMS-010, and CMS-014 in issue tracker