v1: uninstall if needed during install

[felipecrs]

Closes pkgxdev/pkgm#6

[felipecrs]

@mxcl I promise this is the last fix I need for pkgx v1 (and then I'll focus to migrate to pkgx v2).

[coveralls]

coverage: 92.163% (-0.07%) from 92.23%
when pulling cc71694 on felipecrs:uninstall-if-needed
into 3f2b858 on pkgxdev:v1/main.

[felipecrs]

This coverage report is a false negative. I'm sure I didn't decrease coverage.

[felipecrs]

@mxcl, this is a gentle ping.

To test this PR, confirm it wasn't working before:

$ deno task run install openjdk.org@17 && deno task run install openjdk.org@21
# first installation succeeds
# second fails because openjdk.org@17 was already installed

Then, clone this PR and repeat.

[mxcl]

I have disabled coveralls from failing PRs since they apparently can’t pick defaults that aren’t insane and despite many attempts to stop it being insane (by tweaking settings) its insanity prevails.

[felipecrs]

I have disabled coveralls from failing PRs since they apparently can’t pick defaults that aren’t insane and despite many attempts to stop it being insane (by tweaking settings) its insanity prevails.

I have the exact same problem using SonarQube for internal projects. It's just insanity, it never works well (comparing coverage of a PR against the coverage of target branch).

I'd personally avoid any tools like that and instead favor good old CLI tools that will collect the coverage for the whole code base and return 0 or not. Some of them have deeper integration with GitHub Actions allow to provide highlight on the lines missing coverage directly in GitHub. I don't know anything about Rust tooling, though.