Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the --yes from what we suggest to the user #263

Merged
merged 1 commit into from
Jan 16, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions installer.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
if ! [ "$major_version" ]; then
major_version=$(pkgx --version | cut -d' ' -f2 | cut -d. -f1)
fi
if [ $major_version -lt 2 ]; then

Check warning on line 21 in installer.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] reported by reviewdog 🐶 Double quote to prevent globbing and word splitting. Raw Output: ./installer.sh:21:12: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
eval "$(pkgx --shellcode)" 2>/dev/null
fi
fi
Expand All @@ -43,7 +43,7 @@
}

_is_ci() {
[ -n "$CI" ] && [ $CI != 0 ]

Check warning on line 46 in installer.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] reported by reviewdog 🐶 Double quote to prevent globbing and word splitting. Raw Output: ./installer.sh:46:21: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
}

_install_pre_reqs() {
Expand All @@ -54,7 +54,7 @@
export DEBIAN_FRONTEND=noninteractive
cmd=$1
shift
$SUDO apt-get $cmd -qq -o=Dpkg::Use-Pty=0 $@
$SUDO apt-get $cmd --yes -qq -o=Dpkg::Use-Pty=0 $@

Check warning on line 57 in installer.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] reported by reviewdog 🐶 Double quote to prevent globbing and word splitting. Raw Output: ./installer.sh:57:21: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check failure on line 57 in installer.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] reported by reviewdog 🐶 Double quote array expansions to avoid re-splitting elements. Raw Output: ./installer.sh:57:55: error: Double quote array expansions to avoid re-splitting elements. (ShellCheck.SC2068)
}
else
apt() {
Expand All @@ -78,7 +78,7 @@
fi

if test -f /etc/debian_version; then
apt update --yes
apt update

# minimal but required or networking doesn’t work
# https://packages.debian.org/buster/all/netbase/filelist
Expand All @@ -92,13 +92,13 @@

case $(cat /etc/debian_version) in
jessie/sid|8.*|stretch/sid|9.*)
apt install --yes libc-dev libstdc++-4.8-dev libgcc-4.7-dev $A $B $C;;
apt install libc-dev libstdc++-4.8-dev libgcc-4.7-dev $A $B $C;;
buster/sid|10.*)
apt install --yes libc-dev libstdc++-8-dev libgcc-8-dev $A $B $C;;
apt install libc-dev libstdc++-8-dev libgcc-8-dev $A $B $C;;
bullseye/sid|11.*)
apt install --yes libc-dev libstdc++-10-dev libgcc-9-dev $A $B $C;;
apt install libc-dev libstdc++-10-dev libgcc-9-dev $A $B $C;;
bookworm/sid|12.*|*)
apt install --yes libc-dev libstdc++-11-dev libgcc-11-dev $A $B $C;;
apt install libc-dev libstdc++-11-dev libgcc-11-dev $A $B $C;;
esac
elif test -f /etc/fedora-release; then
$SUDO yum --assumeyes install libatomic
Expand Down Expand Up @@ -137,7 +137,7 @@
$SUDO sh -c "
mkdir -p /usr/local/bin
tar xz --directory /usr/local/bin < '$pipe'
install -m 755 "$tmpdir/pkgm" /usr/local/bin

Check warning on line 140 in installer.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] reported by reviewdog 🐶 Double quote to prevent globbing and word splitting. Raw Output: ./installer.sh:140:23: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
" &
wait

Expand Down Expand Up @@ -169,10 +169,10 @@
else
new_version=$(curl -Ssf https://pkgx.sh/VERSION)
old_version=$(/usr/local/bin/pkgx --version || echo pkgx 0)
old_version=$(echo $old_version | cut -d' ' -f2)

Check warning on line 172 in installer.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] reported by reviewdog 🐶 Double quote to prevent globbing and word splitting. Raw Output: ./installer.sh:172:24: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
major_version=$(echo $new_version | cut -d. -f1)

Check warning on line 173 in installer.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] reported by reviewdog 🐶 Double quote to prevent globbing and word splitting. Raw Output: ./installer.sh:173:26: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

/usr/local/bin/pkgx --silent semverator gt $new_version $old_version

Check warning on line 175 in installer.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] reported by reviewdog 🐶 Double quote to prevent globbing and word splitting. Raw Output: ./installer.sh:175:48: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check warning on line 175 in installer.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] reported by reviewdog 🐶 Double quote to prevent globbing and word splitting. Raw Output: ./installer.sh:175:61: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
fi
}

Expand Down
Loading