-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade and pin Vale to v3 #31
Conversation
- Follow some of Vale's suggestions and fix errors and warnings. - Add GitHub Workflow to build docs and run checks on links, spelling, grammar, and style.
@davisagli I was today days old when I learned that This PR should handle the downstream issues that may arise from documentation. I also just realized that eventually any project that uses this theme could have a simplified Thanks for the nudge to pin packages. I never fully understood the benefits. |
@stevepiercy Btw, there are tools that can take a list of unpinned packages and generate a requirements.txt with the current latest pins. I used to use pip-tools for this: https://hynek.me/til/pip-tools-and-pyproject-toml/ But now I would use uv, because it's faster and can correctly handle cases where the dependencies are resolved differently on different platforms. https://docs.astral.sh/uv/pip/compile/ |
Challenge accepted! I realize the deps could be better organized into 3 different buckets: install, develop, and release. Right now they're not well separated. |
Merging, and moving on to improving dep management with |
📚 Documentation preview 📚: https://plone-sphinx-theme--31.org.readthedocs.build/