Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Guide Cookieplone review #6290

Merged
merged 3 commits into from
Sep 14, 2024
Merged

Upgrade Guide Cookieplone review #6290

merged 3 commits into from
Sep 14, 2024

Conversation

stevepiercy
Copy link
Collaborator

@stevepiercy stevepiercy commented Sep 14, 2024

Copy link

netlify bot commented Sep 14, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 29eb0b1
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66e4d6e8cb335300081a2f93

Copy link
Member

@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I dislike the "Sponsored OSS Docker images" naming.
For me it's the recommended community published Docker Image, the fact that it's right now in Docker Hub is circumstantial and could change in the future, eg. hosted in GH.

@sneridagh sneridagh merged commit 08aab5a into main Sep 14, 2024
71 checks passed
@sneridagh sneridagh deleted the upgrade-guide-review branch September 14, 2024 16:51
@stevepiercy
Copy link
Collaborator Author

Yeah, I'm not thrilled about the naming, either, but we have an "Official" Plone image (which IMO should be deprecated to avoid confusion for Plone 6) https://hub.docker.com/_/plone.

I forgot to ask, in the Upgrade Guide, we mention that developers need to adapt their projects to the new way of doing things, but we don't tell them how to do that. I think that should also go into the Upgrade Guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants