-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add prop types to tsx components #3035
base: dev
Are you sure you want to change the base?
Conversation
Ah ok - so after that can we remove |
It hasn't been needed since the components are generated in files, think it was only kept around in the libraries after for compatibilities with older version. The runtime component loader will be removed too. There might be some usage with docs. |
@T4rk1n do you want this one in the release or save it for after? |
Yes this shouldl go into dash 3.0 since it requires components dev to regenerate it would go at the same as the typing generation. |
Fix #3014
We use the
propTypes
defined on the react components to provide runtime prop validation on dash components. This property is missing from typescript components as they don't define that attribute, this PR generate propTypes for the components using the extracted metadata and saves it in aproptypes.js
in the package directory. This file should be added as a dev dependencies in the package__init__.py
_js_dist
like this: