Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests #126

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Fix integration tests #126

merged 1 commit into from
Sep 5, 2024

Conversation

adangel
Copy link
Member

@adangel adangel commented Sep 5, 2024

Add a maven-settings.xml for building (old) PMD versions with another maven repository, since dokka-maven-plugins uses a dependency (kotlinx-html-jvm) which was once available via jcenter.bintray.com, but bintray.com no longer exists today.

Add a maven-settings.xml for building (old) PMD versions with
another maven repository, since dokka-maven-plugins uses a dependency
(kotlinx-html-jvm) which was once available via jcenter.bintray.com, but
bintray.com no longer exists today.
@adangel adangel added this to the next milestone Sep 5, 2024
@jsotuyod
Copy link
Member

jsotuyod commented Sep 5, 2024

I'm a little confused here…

If I understand correctly, the issue lies with the dokka-maven-plugin declared by pmd-lang-test referencing a dependency (kotlinx-html-jvm) that is not available in maven central, but on the now defunct jcenter… now, if that's the case, shouldn't this also fail when building pmd-lang-test directly from the pmd repo? shouldn't this be fixed there rather than here?

adangel added a commit that referenced this pull request Sep 5, 2024
adangel added a commit that referenced this pull request Sep 5, 2024
Merge pull request #126 from adangel:fix-integration-tests
@adangel adangel merged commit c3277b6 into pmd:master Sep 5, 2024
1 check passed
@adangel adangel deleted the fix-integration-tests branch September 5, 2024 13:12
@adangel adangel added the bug Something isn't working label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants