The schedule 0, 1, get_coin(), ... #76
Conversation
vkomenda
force-pushed
the
vk-coin-schedule
branch
from
14072bc
to
2d899a1
Compare
vkomenda
force-pushed
the
vk-coin-schedule
branch
from
2d899a1
to
7a4fc37
Compare
src/agreement/mod.rs
Outdated
| @@ -201,6 +211,7 @@ impl<NodeUid: Clone + Debug + Ord> Agreement<NodeUid> { | |||
| netinfo, | |||
| Nonce::new(invocation_id.as_ref(), session_id, proposer_i, 0), | |||
| ), | |||
| coin_schedule: CoinSchedule::False, | |||
There was a problem hiding this comment.
I think there was an argument for starting with True: In the best case scenario, where everyone gets their proposals delivered in time, everyone would vote true in every instance, and it would be nice to terminate in the first round then.
Also, it is probably generally preferred to err on the true side and include more elements in the common subset, and therefore more transactions in the epoch.
src/agreement/mod.rs
Outdated
| fn coin_schedule(&self) -> CoinSchedule { | ||
| match self.epoch % 3 { | ||
| 0 => CoinSchedule::False, | ||
| 1 => CoinSchedule::True, |
There was a problem hiding this comment.
As above, I'd swap True and False here.
| self.common_coin = CommonCoin::new(self.netinfo.clone(), nonce); | ||
| self.coin_schedule = self.coin_schedule(); |
There was a problem hiding this comment.
Do we need the coin schedule as a member variable at all? Isn't it easier to just call self.coin_schedule() where it's needed?
There was a problem hiding this comment.
I didn't want to make a call on every Aux message.
Close #69
This branch depends on PR #68.