Address review comments #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Locking DRA manager is not required. Locking a cache should be enough.
Moved DRA plugin registration up just beneath the CSI plugin since it symmetrical to that.
bart0sh
force-pushed
the
PR021-address-review-comments
branch
from
6613bac to
50acd32
Compare
8 tasks
klueska
reviewed
Nov 4, 2022
Co-authored-by: Kevin Klues <[email protected]>
Co-authored-by: Kevin Klues <[email protected]>
Co-authored-by: Kevin Klues <[email protected]>
bart0sh
force-pushed
the
PR021-address-review-comments
branch
from
f1bee67 to
65ebb24
Compare
klueska
reviewed
Nov 4, 2022
pohly
pushed a commit
that referenced
this pull request
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.