Finish Lab #3
Open
Finish Lab #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmckeon
approved these changes
Aug 22, 2024
| @@ -0,0 +1,31 @@ | |||
| class PizzasController < ApplicationController | |||
| def new | |||
| puts params | |||
There was a problem hiding this comment.
3 weeks of asking you to stop committing this!!!!! If I see this on the actual code challenge, I'm going to fail you immediately.
| @pizza = Pizza.new(pizza_params) | ||
|
|
||
| if @pizza.save | ||
| redirect_to pizza_path @pizza, notice: 'Pizza was successfully created.' |
There was a problem hiding this comment.
If you're not handling the notice, don't include it in the redirect. As of now, it does nothing.
Comment on lines
+2
to
+5
| belongs_to :pizzeria | ||
| validates :name, presence: true | ||
| validates :description, presence: true | ||
| validates :pizzeria_id, presence: true |
There was a problem hiding this comment.
Suggested change
| belongs_to :pizzeria | |
| validates :name, presence: true | |
| validates :description, presence: true | |
| validates :pizzeria_id, presence: true | |
| belongs_to :pizzeria | |
| validates :name, :description, :pizzeria_id, presence: true |
Comment on lines
+2
to
+4
| has_many :pizzas | ||
| validates :name, presence: true, uniqueness: true | ||
| validates :address, presence: true, uniqueness: true |
There was a problem hiding this comment.
Suggested change
| has_many :pizzas | |
| validates :name, presence: true, uniqueness: true | |
| validates :address, presence: true, uniqueness: true | |
| has_many :pizzas | |
| validates :name, presence: true, uniqueness: true | |
| validates :address, presence: true, uniqueness: true |
Comment on lines
+15
to
+17
| <% if @pizzeria.present? %> | ||
| <%= f.hidden_field :pizzeria_id, value: @pizzeria.id %> | ||
| <% end %> |
There was a problem hiding this comment.
The conditional wouldn't be needed if you set @pizzeria in the create action.
| resources :pizzas, only: [:new, :create, :show] | ||
| end | ||
|
|
||
| resources :pizzas, only: [:new, :create, :show] |
There was a problem hiding this comment.
Shouldn't need this line.
Suggested change
| resources :pizzas, only: [:new, :create, :show] |
There was a problem hiding this comment.
Don't commit files/changes that don't involve your changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create all needed features.