Django 2.1 support #32
Conversation
.travis.yml
Outdated
| - TOXENV=django110-py36 | ||
| - TOXENV=django111-py36 | ||
| include: | ||
| - python: 2.7 |
There was a problem hiding this comment.
List these envs the same way please. No need for the separation the be this granular.
| @@ -0,0 +1,2 @@ | |||
| Django~=1.11.15 | |||
There was a problem hiding this comment.
These requirements can be listed directly in the tox.ini file. No need for separate files for two requirements.
There was a problem hiding this comment.
See https://github.com/praekelt/django-object-tools/blob/develop/tox.ini as an example
| @@ -0,0 +1,2 @@ | |||
| Django>=2.0,<2.1 | |||
There was a problem hiding this comment.
See comment above about requirements
| @@ -0,0 +1,2 @@ | |||
| Django>=2.1,<2.2 | |||
There was a problem hiding this comment.
See comment above about requirements
export/tools.py
Outdated
| @@ -101,4 +101,5 @@ def view(self, request, extra_context=None, process_form=True): | |||
| context, | |||
| ) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
PEP 8: expected 2 blank lines after class or function definition, found 1
| deps = | ||
| coverage | ||
| django111: django>=1.11,<2.0 | ||
| django110: django>=1.10,<1.11 | ||
| django19: django>=1.9,<1.10 | ||
| django20: django>=2.0,<2.1 |
There was a problem hiding this comment.
Seeing that you have these here, all the requirements files for the tests can be removed
Added support for Django 2.1 and included coveralls