Fix log callers when the cleanup uses t.Helper()
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If every function in `t.Cleanup` uses `t.Helper()` and logs, then the caller information skips to the caller of `t.Cleanup`. Track the caller of `Cleanup` and use that instead of reporting faketb as caller.
prashantv
force-pushed
the
prashant/cleanup-helper
branch
from
3f8e965 to
13ece45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If every function in
t.Cleanupusest.Helper()and logs, then the caller information skips to the caller oft.Cleanup. Track the caller ofCleanupand use that instead of reporting faketb as caller.