Refactor Logs APIs and implementation #20
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestResult.Logs()
now returns a list of structured entries for logs.Most callers will likely rely on
Logs.String()
to get a concatenated stringof all logs, in a format similar to
go test
. However, tests can also get alist of messages, or work with the
Log
entry directly.The log entry includes the message, caller information, and the
testing.TB
function that was used to log. In the future, we can include caller PCs if
there's use-cases, but PCs are not exposed due to the complexity of
merging caller PCs across the log caller, and possibly a cleanup caller.