Fix panics setting TestResult asynchronously #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panic handling is deferred before the defer that marks tests complete. This could lead to a test being marked complete, returning a result but then mutating that result after returning. This happened infrequently but could lead to a flaky result where a panicked test isn't marked as `Failed()`. Added test runs many iterations so we are more likely to trigger a failure on flakes. Add `syncutil` to run iteraitons in parallel without adding significant noise to the test.
prashantv
force-pushed
the
prashant/faket-panic-race
branch
from
fca59a1 to
c875974
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Panic handling is deferred before the defer that marks tests complete. This could lead to a test being marked complete, returning a result but then mutating that result after returning.
This happened infrequently but could lead to a flaky result where a panicked test isn't marked as
Failed(). Added test runs many iterations so we are more likely to trigger a failure on flakes.