Skip to content

Commit

Permalink
test: Remove commented-out test cases
Browse files Browse the repository at this point in the history
  • Loading branch information
rschristian committed Aug 31, 2024
1 parent 5d7bb24 commit e551281
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions test/router.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ describe('Router', () => {
expect(scratch).to.have.property('innerHTML', '<h1>A</h1><p>hello</p>');
// We should never re-invoke <A /> while loading <B /> (that would be a remount of the old route):
// ...but we do
// expect(A).not.to.have.been.called;
expect(A).not.to.have.been.called;
expect(B).to.have.been.calledWith({ path: '/b', query: {}, params: {}, rest: '' });

B.resetHistory();
Expand All @@ -268,7 +268,7 @@ describe('Router', () => {
expect(scratch).to.have.property('innerHTML', '<h1>B</h1><p>hello</p>');
// We should never re-invoke <B /> while loading <C /> (that would be a remount of the old route):
// ...but we do
//expect(B).not.to.have.been.called;
expect(B).not.to.have.been.called;
expect(C).to.have.been.calledWith({ path: '/c', query: {}, params: {}, rest: '' });

C.resetHistory();
Expand All @@ -286,9 +286,10 @@ describe('Router', () => {

expect(scratch).to.have.property('innerHTML', '<h1>B</h1><p>hello</p>');
expect(C).not.to.have.been.called;
// expect(B).to.have.been.calledOnce();
expect(B).to.have.been.calledOnce;
expect(B).to.have.been.calledWith({ path: '/b', query: {}, params: {}, rest: '' });

A.resetHistory();
B.resetHistory();
loc.route('/');
await sleep(1);
Expand Down

0 comments on commit e551281

Please sign in to comment.