feat: Adds scope prop to LocationProvider, limiting link intercepts
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
changed the title
limit prop to LocationProvider, limiting link intercepts
README.md
Outdated
| @@ -82,6 +82,10 @@ export async function prerender(data) { | |||
|
|
|||
| A context provider that provides the current location to its children. This is required for the router to function. | |||
|
|
|||
| Props: | |||
|
|
|||
| - `limit?: string | RegExp` - Sets a limit on the paths that the router will handle (intercept). If a path does not match the limit, either by starting with the provided string or matching the RegExp, the router will ignore it and default browser navigation will apply. | |||
There was a problem hiding this comment.
The name limit bothers me a bit, I would prefer something like include/exclude personally
There was a problem hiding this comment.
Hm, "include" means something quite different though. To include something is to have it be part of a whole; this limits the whole to only the matching value.
There's probably a better name somewhere (haven't yet found/thought of one myself), though I think "include" would give a very different idea than what we're going for. Just my initial thoughts though.
There was a problem hiding this comment.
Maybe scope? I'm not dead-set against include, can do it, though not my fav.
rschristian
changed the title
limit prop to LocationProvider, limiting link interceptsscope prop to LocationProvider, limiting link intercepts
rschristian
force-pushed
the
feat/limit
branch
from
1ace85d to
86a173e
Compare
JoviDeCroock
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34
Allows users to opt-out of link interception, setting a string & regexp scope that intercepts should be limited to, e.g.,
<LocationProvider scope="/app">will ignore clicks to/site.