Release v2.0.0 #167
Release v2.0.0 #167
Conversation
* Update citation cff * Update ReleaseGuide.md * Refer to preCICE Literature guide
* Let the games begin :) * should still fail? * lets try again with a bit more logic * seperate dockerfile concerns in pythonbinding_ref and adapter ref * adopt to pythonbindings --------- Co-authored-by: Valentin Seitz <[email protected]> Co-authored-by: Ishaan Desai <[email protected]>
Link is again broken. Decided to remove it after just fixing it via #157
* Remove API functions that are removed in v3.0.0. Fix data initialization. * Forward dt to python bindings. * Set mesh connectivity information only if it is required. Closes #138 * Update tests * Update links of contributors * Update CHANGELOG.md * Call checkpointing functions from the interface * Change required version of pyprecice to >=3.0.0.0 * Comment out nearest projection volume coupling. --------- Co-authored-by: Ishaan Desai <[email protected]>
BenjaminRodenberg
added
compatibility
breaking change
Normally, this is no reason for a major release. In the end, preCICE is only a dependency. Similar discussion for the OpenFOAM adapter: precice/openfoam-adapter#319 (comment) |
But a FEniCS user calls the adapter API in their code, so their code will break when we release. This is fundamentally different than how the OpenFOAM adapter is used. Does this not warrant a major release? |
|
@uekerman for the FEniCS adapter we have to do a breaking release, if we want to support preCICE v3. See #153 and how the API of the adapter changes. We also had to updates all the tutorials. See precice/tutorials@63273dd. |
Co-authored-by: Ishaan Desai <[email protected]>
BenjaminRodenberg
force-pushed
the
fenics-adapter-v2.0.0
branch
from
9965a9d to
47dc07e
Compare
This is mainly a compatibility release for the major preCICE release v3.0.0 https://github.com/precice/precice/releases/tag/v3.0.0. This especially breaks compatibility of the FEniCS adapter with older preCICE versions and is therefore considered as a major release of the FEniCS adapter.
The remaining changes are mainly minor bugfixes and documentation updates.